Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage the management client to make api requests in api cmd #681

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Mar 17, 2023

🔧 Changes

This PR changes the internals of the auth0 api command to leverage the already configured Auth0 Go SDK to execute the requests, in order to leverage the retries and access token that is already configured on the client.

📚 References

🔬 Testing

This change is covered by the tests we already have and a few extra ones.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught marked this pull request as ready for review March 17, 2023 14:14
@sergiught sergiught requested a review from a team as a code owner March 17, 2023 14:14
@sergiught sergiught marked this pull request as draft March 17, 2023 14:14
@sergiught sergiught marked this pull request as ready for review March 17, 2023 15:13
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.05 ⚠️

Comparison is base (200ea69) 54.43% compared to head (0a5e89d) 54.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #681      +/-   ##
==========================================
- Coverage   54.43%   54.38%   -0.05%     
==========================================
  Files          89       89              
  Lines       11510    11515       +5     
==========================================
- Hits         6265     6263       -2     
- Misses       4796     4802       +6     
- Partials      449      450       +1     
Impacted Files Coverage Δ
internal/cli/api.go 76.38% <46.66%> (-3.11%) ⬇️
internal/auth0/auth0.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sergiught
Copy link
Contributor Author

Codecov message is outdated: https://app.codecov.io/gh/auth0/auth0-cli/pull/681 this pr increases code coverage by 0.08%.

@sergiught sergiught merged commit 054145b into main Mar 17, 2023
@sergiught sergiught deleted the patch/api-cmd-retries branch March 17, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants