Return empty array when using --json flag for list commands

[sergiught]

🔧 Changes

When returning the output of a list command in combination with the --json flag, if there are no elements to display we should still return an empty array.

📚 References

🔬 Testing

📝 Checklist

• All new/changed/fixed functionality is covered by tests (or N/A)
• I have added documentation for all new/changed functionality (or N/A)

[codecov-commenter]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (59a0cad) 70.60% compared to head (2875a4a) 70.61%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #736   +/-   ##
=======================================
  Coverage   70.60%   70.61%           
=======================================
  Files          87       87           
  Lines       11197    11198    +1     
=======================================
+ Hits         7906     7907    +1     
  Misses       2778     2778           
  Partials      513      513           

Impacted Files	Coverage Δ
internal/display/display.go	86.70% <100.00%> (+0.07%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Widcket]

Should we add this assert to all other existing list integration tests?

[Widcket]

Except for apps and apis, those will never be empty.

[Widcket]

(by assert I mean the "contain" on "stdout").

[willvedd]

Change makes sense and solves a very real pain point. Satisfied with the coverage provided by unit test + example integration test.

[sergiught]

@Widcket we added unit tests for the renderer func + used it in 1 integration test. We felt it was enough for now :)

[Widcket]

It's not about the coverage, it's about the other integration tests that did not have an assert on the output.

[Widcket]

Of course, however you prefer.

[Widcket]

This PR finally makes it possible to assert on the output of empty lists.

[Widcket]

And there being a single function doing the output is an implementation detail, which is not relevant from the perspective of black-box integration tests.

[sergiught]

@Widcket completely agreed, we can follow up in another PR to have those covered as well. We're mostly just trying to use our time wisely at the moment for the upcoming release. :)

[Widcket]

Of course, prioritize as you must.