DXCDT-90: Adding log streams support #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 13, 2022 21:08
…to DXCDT-90-adding-log-streams
sergiught
approved these changes
Apr 19, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ Changes
Adding support for creating, updating and deleting log streams. There are several external dependencies that log streams integrate with (eventbridge, eventgrid, datadog, http, splunk, sumo) which makes this configuration management a bit tricky and subject to finicky failures, however through a combination of stripping payload fields on update and create (#496), the reliability of log stream management improves.
It is possible for log streams to be in a "suspended" state after some time, from what I can tell, that state switching is an outside process and you cannot put a log stream into a suspended state directly, nor can you reliably create or update suspended log streams, for that reason, the deploy CLI purposefully ignores those and will only manage those in an active or paused state.
🔗 References
Relevant Github issue: #254
🎯 Testing
Mocked integration tests added to bring this feature in line with the existing codebase's testing level.