Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS coverage reporting #139

Merged
merged 5 commits into from
Jul 22, 2022
Merged

Fix iOS coverage reporting #139

merged 5 commits into from
Jul 22, 2022

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Jul 22, 2022

Description

This PR fixes the iOS coverage reporting:

Screen Shot 2022-07-22 at 01 54 28

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket added the review:tiny Tiny review label Jul 22, 2022
@Widcket Widcket requested a review from a team as a code owner July 22, 2022 04:56
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #139 (4fbaf5a) into first-availability (b38e776) will increase coverage by 2.70%.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##             first-availability     #139      +/-   ##
========================================================
+ Coverage                 93.31%   96.02%   +2.70%     
  Complexity                   69       69              
========================================================
  Files                        51       75      +24     
  Lines                       793     1384     +591     
  Branches                     43      294     +251     
========================================================
+ Hits                        740     1329     +589     
  Misses                       46       46              
- Partials                      7        9       +2     
Flag Coverage Δ
auth0_flutter 100.00% <ø> (ø)
auth0_flutter_android 90.49% <ø> (ø)
auth0_flutter_ios 99.66% <ø> (?)
auth0_flutter_platform_interface 96.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/Classes/AuthAPI/AuthAPISignupMethodHandler.swift 100.00% <0.00%> (ø)
...os/Classes/WebAuth/WebAuthLoginMethodHandler.swift 100.00% <0.00%> (ø)
...dentialsManager/CredentialsManagerExtensions.swift 93.75% <0.00%> (ø)
...0_flutter/ios/Classes/WebAuth/WebAuthHandler.swift 100.00% <0.00%> (ø)
auth0_flutter/ios/Classes/Extensions.swift 100.00% <0.00%> (ø)
.../CredentialsManager/CredentialsManagerModels.swift 100.00% <0.00%> (ø)
...lsManager/CredentialsManagerGetMethodHandler.swift 95.00% <0.00%> (ø)
...CredentialsManager/CredentialsManagerHandler.swift 100.00% <0.00%> (ø)
auth0_flutter/ios/Classes/HandlerError.swift 100.00% <0.00%> (ø)
...API/AuthAPILoginUsernameOrEmailMethodHandler.swift 100.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b38e776...4fbaf5a. Read the comment docs.

@Widcket Widcket merged commit 32cd5c6 into first-availability Jul 22, 2022
@Widcket Widcket deleted the fix/ios-coverage branch July 22, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:tiny Tiny review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants