add config argument to loginWithPopup (#77)

auth0 · Aug 4, 2020 · caa2d09 · caa2d09
1 parent 387b3d4
commit caa2d09
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/src/auth0-context.tsx b/src/auth0-context.tsx
@@ -6,6 +6,7 @@ import {
   IdToken,
   LogoutOptions,
   PopupLoginOptions,
+  PopupConfigOptions,
 } from '@auth0/auth0-spa-js';
 import { createContext } from 'react';
 import { AuthState, initialAuthState } from './auth-state';
@@ -100,7 +101,7 @@ export interface Auth0ContextInterface extends AuthState {
 
   /**
    * ```js
-   * await loginWithPopup(options);
+   * await loginWithPopup(options, config);
    * ```
    *
    * Opens a popup with the `/authorize` URL using the parameters
@@ -112,7 +113,10 @@ export interface Auth0ContextInterface extends AuthState {
    * that was started by the user like a button click, for example,
    * otherwise the popup will be blocked in most browsers.
    */
-  loginWithPopup: (options?: PopupLoginOptions) => Promise<void>;
+  loginWithPopup: (
+    options?: PopupLoginOptions,
+    config?: PopupConfigOptions
+  ) => Promise<void>;
 
   /**
    * ```js

diff --git a/src/auth0-provider.tsx b/src/auth0-provider.tsx
@@ -5,6 +5,7 @@ import {
   CacheLocation,
   IdToken,
   PopupLoginOptions,
+  PopupConfigOptions,
   RedirectLoginOptions as Auth0RedirectLoginOptions,
 } from '@auth0/auth0-spa-js';
 import Auth0Context, { RedirectLoginOptions } from './auth0-context';
@@ -207,10 +208,13 @@ const Auth0Provider = (opts: Auth0ProviderOptions): JSX.Element => {
     })();
   }, [client, onRedirectCallback]);
 
-  const loginWithPopup = async (options?: PopupLoginOptions): Promise<void> => {
+  const loginWithPopup = async (
+    options?: PopupLoginOptions,
+    config?: PopupConfigOptions
+  ): Promise<void> => {
     dispatch({ type: 'LOGIN_POPUP_STARTED' });
     try {
-      await client.loginWithPopup(options);
+      await client.loginWithPopup(options, config);
     } catch (error) {
       dispatch({ type: 'ERROR', error: loginError(error) });
       return;
@@ -234,7 +238,7 @@ const Auth0Provider = (opts: Auth0ProviderOptions): JSX.Element => {
           client.getIdTokenClaims(opts),
         loginWithRedirect: (opts): Promise<void> =>
           client.loginWithRedirect(toAuth0LoginRedirectOptions(opts)),
-        loginWithPopup: (opts): Promise<void> => loginWithPopup(opts),
+        loginWithPopup,
         logout: (opts): void => client.logout(opts),
       }}
     >