Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Auth0-SPA-JS to latest version #690

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Dec 11, 2023

Description

Updates SPA-JS to the latest version to add support for workerUrl.

References

https://github.com/auth0/auth0-spa-js/releases/tag/v2.1.3

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@frederikprijck frederikprijck merged commit 0518369 into main Dec 11, 2023
16 checks passed
@frederikprijck frederikprijck deleted the feat/update-spa-js branch December 11, 2023 16:11
@frederikprijck frederikprijck mentioned this pull request Dec 11, 2023
frederikprijck added a commit that referenced this pull request Dec 11, 2023
**Changed**
- Update Auth0-SPA-JS to latest version
[\#690](#690)
([frederikprijck](https://github.com/frederikprijck))
@@ -96,6 +96,6 @@
"react-dom": "^16.11.0 || ^17 || ^18"
},
"dependencies": {
"@auth0/auth0-spa-js": "^2.1.2"
"@auth0/auth0-spa-js": "^2.1.3"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frederikprijck This is causing issue for login. As we have set prompt and login which reset to none. It has issue during call of getAccessTokenSilently which saying error as 'Failed Silent Auth' and Login required

Copy link
Member Author

@frederikprijck frederikprijck Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see how that would be caused by that version bump to SPA-JS. All we did was add additional functionality that is opt-in, see https://github.com/auth0/auth0-spa-js/releases/tag/v2.1.3.

If you believe it does, please open an issue demonstrating the behavior caused by the SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants