[SDK-1994] GMaps breaks SPA JS on IE11 #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjmcgrath
changed the title
Symbol polyfill which breaks core-js's Array.from polyfill
Widcket
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Google Maps adds a
Symbolpolyfill which causescore-js'sArray.frompolyfill to incorrectly return an empty array, eg when doingdedupe = (a) => Array.from(new Set(a))(https://github.com/auth0/auth0-spa-js/blob/master/src/scope.ts#L4)To fix see the 2 worksrounds in zloirock/core-js#618
import 'core-js/es6/symbol';before importingarray-fromSince we can't expect customers to do #1, we should do #2 (adds 2.9kb GZipped to the spa binary)
References
https://auth0team.atlassian.net/browse/ESD-9069
zloirock/core-js#618 (comment)
Testing
Add the Google Maps JS API v3 to your page after the SPA SDK
Login through the SPA JS SDK
Expected Behavior
The user is logged in
Actual Behavior
The handle redirect callback will fail with "ID Token is required but missing"