Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the default token validation leeway to 60 sec #1062

Merged
merged 2 commits into from
Dec 17, 2019
Merged

Set the default token validation leeway to 60 sec #1062

merged 2 commits into from
Dec 17, 2019

Conversation

stevehobbsdev
Copy link
Contributor

@stevehobbsdev stevehobbsdev commented Dec 17, 2019 •
edited
Loading

Changes

This sets the default leeway for validating tokens to 60 seconds, in alignment with idtoken-verifier.

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage

Checklist

@stevehobbsdev stevehobbsdev requested a review from a team December 17, 2019 17:14
joshcanhelp
joshcanhelp previously approved these changes Dec 17, 2019
View reviewed changes
@nicosabena
Copy link
Member

Fixes #1061

@nicosabena nicosabena mentioned this pull request Dec 17, 2019
Closed
@stevehobbsdev stevehobbsdev merged commit e58310e into master Dec 17, 2019
@stevehobbsdev stevehobbsdev deleted the fix/default-validation-leeway branch December 17, 2019 20:59
@stevehobbsdev stevehobbsdev added this to the v9.12.1 milestone Dec 17, 2019
@stevehobbsdev stevehobbsdev mentioned this pull request Dec 17, 2019
Merged
9 tasks
@snyk-bot snyk-bot mentioned this pull request Feb 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshcanhelp joshcanhelp joshcanhelp approved these changes

Assignees
No one assigned
Labels
CH: Fixed
Projects
None yet
Milestone
v9.12.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stevehobbsdev @nicosabena @joshcanhelp