Set the default token validation leeway to 60 sec #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
approved these changes
Dec 20, 2019
jfromaniello
pushed a commit
to jfromaniello/auth0-lock
that referenced
this pull request
Mar 5, 2020
* Bumped auth0-js to 9.12.1 * Update default leeway to 60 sec
jfromaniello
pushed a commit
to jfromaniello/auth0-lock
that referenced
this pull request
Jul 23, 2020
* Bumped auth0-js to 9.12.1 * Update default leeway to 60 sec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR bumps Auth0.js to 9.12.1 to take advantage of a new default leeway. It also changes the default leeway specified by Lock to align with Auth0.js to 60 seconds.
References
Aligns with this change: auth0/auth0.js#1062
Testing
Unit test coverage added. It's not immediately obvious from the way the diff has worked out, but the change is verified in the form of an additional snapshot. Existing tests used a leeway of 60 seconds; these were changed to 30 seconds to distinguish these tests from the new test that sends the default of 60.
Checklist