This repository has been archived by the owner on May 17, 2023. It is now read-only.
Add replacement to deprecation warning (in dev console) #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new list component will be a suitable replacement for resource list once it's merge and we build all the examples |
siddharthkp
changed the title
siddharthkp
added
🖼️design / ux
|
@siddharthkp we can remove it, yes. |
francocorreasosa
approved these changes
Jan 15, 2019
landitus
pushed a commit
that referenced
this pull request
Jan 17, 2020
* show the html default first * throw validation error not warning
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1388
There was just one place where we didn't have a replacement:
ResourceList.ItemFound a rogue file that isn't imported anywhere: https://github.com/auth0/cosmos/blob/master/core/components/_helpers/icon-prop.js, @francocorreasosa can we delete this?
Unrelated change: Changed the first item in
Buttonproptypetosubmitso that it shows up first (that's the html default)