Skip to content
This repository has been archived by the owner on May 17, 2023. It is now read-only.

Better class names for debugging #712

Closed
wants to merge 1 commit into from
Closed

Conversation

siddharthkp
Copy link
Contributor

@siddharthkp siddharthkp commented Jul 23, 2018

Fixes #166

This changes ALL the class names and hence all the chromatic snapshots need approval

Converts

<button class="sc-dnqmqq jTtzor" icon="apis">
  <i class="sc-bwzfXH fRCcvq">
    <svg class="sc-htpNat WAuWX"></svg>
  </i>
  <span class="sc-gZMcBi gZDevs">Button</span>
</button>

to

<button class="button__Element-kXFKBl eJZKsk" icon="apis">
  <i class="icon__Element-hNoGcs fCXlyr">
    <svg class="icon__Image-HcNJc ecgQOf"></svg>
  </i>
  <span class="button__Text-csEsbi eoVnij">Button</span>
</button>

@siddharthkp siddharthkp added ✨enhancement ...improvements 🛠️ tooling beep boop blop labels Jul 23, 2018
@siddharthkp siddharthkp changed the title add babel-plugin-styled-components Better class names for debugging Jul 23, 2018
@siddharthkp siddharthkp added this to Backlog in PoC Expansion via automation Jul 23, 2018
@siddharthkp siddharthkp moved this from Backlog to Needs Review in PoC Expansion Jul 23, 2018
@siddharthkp siddharthkp added the ✋don't merge PRs that are blocked / paused at the moment label Jul 24, 2018
@siddharthkp siddharthkp moved this from Needs Review to In Progress in PoC Expansion Jul 26, 2018
@siddharthkp
Copy link
Contributor Author

siddharthkp commented Jul 27, 2018

Added don't-merge because this disables the class^="sc-" hack that we have in place

https://github.com/auth0/cosmos/blob/master/core/components/_helpers/globals.js#L84

@siddharthkp
Copy link
Contributor Author

Closing this because it breaks the ^sc- hack.

The right solution depends on this discussion: https://github.com/orgs/auth0/teams/design-system/discussions/24?from_comment=1#discussion-24-comment-1

@siddharthkp siddharthkp moved this from In Progress to Backlog in PoC Expansion Jul 31, 2018
@siddharthkp siddharthkp removed this from Backlog in PoC Expansion Aug 7, 2018
@siddharthkp siddharthkp added this to To do in Backlog Sep 3, 2018
@siddharthkp siddharthkp removed this from To do in Backlog Sep 3, 2018
@siddharthkp siddharthkp deleted the debug-classes branch September 28, 2018 14:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✋don't merge PRs that are blocked / paused at the moment ✨enhancement ...improvements 🛠️ tooling beep boop blop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant