-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-4226] Update all methods to accept a ctx argument #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## beta #212 +/- ##
=======================================
Coverage ? 95.28%
=======================================
Files ? 38
Lines ? 7358
Branches ? 0
=======================================
Hits ? 7011
Misses ? 276
Partials ? 71 ☔ View full report in Codecov by Sentry. |
sergiught
previously approved these changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪🏻
Co-authored-by: Sergiu Ghitea <28300158+sergiught@users.noreply.github.com>
sergiught
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Updates all methods to now accept a
context.Context
parameter directly rather than via theContext
orWithContext
helper.For example
is now
📚 References
🔬 Testing
📝 Checklist
WithClientCredentials
andWithClientCredentialsAndAudience
functions must now pass aContext
as the first argumentContext
as the first argumentmanagement.WithContext
andmanagement.Context
helpers have been removed, in favour of the above two options of passing theContext
as the first argument