Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add method to unlink a users identity #35

Merged
merged 3 commits into from
Apr 7, 2022
Merged

add method to unlink a users identity #35

merged 3 commits into from
Apr 7, 2022

Conversation

fschoell
Copy link
Contributor

@fschoell fschoell commented Mar 15, 2022 •
edited
Loading

Description

adds a method to unlink a users identity

References

https://auth0.com/docs/api/management/v2#!/Users/delete_user_identity_by_user_id

Testing

Checklist

  • I have read and agreed to the terms within the Auth0 Code of Conduct.
  • I have read the Auth0 General Contribution Guidelines.
  • I have reviewed my own code beforehand.
  • I have added documentation for new/changed functionality in this PR.
  • All active GitHub checks for tests, formatting, and security are passing.
  • The correct base branch is being used, if not main.

@fschoell fschoell requested a review from a team as a code owner March 15, 2022 17:27
@sergiught
Copy link
Contributor

Hey @fschoell, thanks for the contribution! Would you mind adding a test for this as well please?:)

@fschoell
Copy link
Contributor Author

@sergiughf added a test case for unlinking

sergiught
sergiught requested changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@sergiught sergiught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @fschoell and apologies this took a while to review.

Please make sure to run make lint to spot those linter errors early:)

Left a few comments that should be easily fixed, great work!

management/user.go Outdated Show resolved Hide resolved
management/user.go Outdated Show resolved Hide resolved
management/user_test.go Outdated Show resolved Hide resolved
management/user_test.go Outdated Show resolved Hide resolved
management/user_test.go Outdated Show resolved Hide resolved
@fschoell
Copy link
Contributor Author

fschoell commented Apr 7, 2022

should all be fixed

sergiught
sergiught approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@sergiught sergiught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the contribution @fschoell! 🥳

@sergiught sergiught merged commit 9ac8228 into auth0:main Apr 7, 2022
@fschoell fschoell deleted the feature/unlink_user_identity branch April 7, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiught sergiught sergiught approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fschoell @sergiught