Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for null token before splitting #606

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Check for null token before splitting #606

merged 3 commits into from
Sep 8, 2022

Conversation

jimmyjames
Copy link
Contributor

Changes

Checks the token for null value before splitting the token parts.

Replaces #587 with additional test. Thanks @anderuraga for raising the original PR!

@jimmyjames jimmyjames added this to the v4-Next milestone Aug 30, 2022
@jimmyjames jimmyjames requested a review from a team as a code owner August 30, 2022 01:44
@jimmyjames jimmyjames mentioned this pull request Aug 30, 2022
Closed
5 tasks
@jimmyjames jimmyjames merged commit 59e4475 into master Sep 8, 2022
@jimmyjames jimmyjames deleted the check-for-null-token branch September 8, 2022 12:03
@jimmyjames jimmyjames modified the milestones: v4-Next, 4.1.0 Sep 9, 2022
@jimmyjames jimmyjames mentioned this pull request Oct 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

Assignees
No one assigned
Labels
CH: Fixed
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmyjames @Widcket