Applied overflow style only on mobile views #1758
Merged
Conversation
|
Just a question regarding real devices otherwise is fine. Did you have the chance to test this on some mobile phones? |
|
@lbalmaceda Not on a real device no, just in the iOS Simulator, which now works as intended. Also in browser dev tools in responsive mode. |
642c222
into
master
3 checks passed
3 checks passed
license/snyk - package.json (auth0-sdks)
No manifest changes detected
security/snyk - package.json (auth0-sdks)
No manifest changes detected
This was referenced Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Changes
Ensures that the
overflow-x: autostyle is only applied to mobile views (< 480px). Otherwise, it breaks the password strength popup on desktop views, as the wrapper can hide the top portion of it.However, the overflow style is needed to fix the "submit" button on mobile views.
Before
After
References
Fixes #1756
Fixes #1705
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist