Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applied overflow style only on mobile views #1758

Merged
merged 1 commit into from Nov 29, 2019
Merged

Conversation

@stevehobbsdev
Copy link
Contributor

@stevehobbsdev stevehobbsdev commented Nov 28, 2019

Changes

Ensures that the overflow-x: auto style is only applied to mobile views (< 480px). Otherwise, it breaks the password strength popup on desktop views, as the wrapper can hide the top portion of it.

However, the overflow style is needed to fix the "submit" button on mobile views.

Before

image

After

image

References

Fixes #1756
Fixes #1705

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@stevehobbsdev stevehobbsdev requested a review from auth0/dx-sdks-approver as a code owner Nov 28, 2019
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Just a question regarding real devices otherwise is fine. Did you have the chance to test this on some mobile phones?

@stevehobbsdev
Copy link
Contributor Author

@stevehobbsdev stevehobbsdev commented Nov 28, 2019

@lbalmaceda Not on a real device no, just in the iOS Simulator, which now works as intended. Also in browser dev tools in responsive mode.

@stevehobbsdev stevehobbsdev added this to the vNext milestone Nov 28, 2019
@stevehobbsdev stevehobbsdev merged commit 642c222 into master Nov 29, 2019
3 checks passed
3 checks passed
ci/circleci: build-and-test Your tests passed on CircleCI!
Details
license/snyk - package.json (auth0-sdks) No manifest changes detected
security/snyk - package.json (auth0-sdks) No manifest changes detected
@stevehobbsdev stevehobbsdev deleted the fix/wrapper-overflow branch Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants