[SDK-1373] Added style rules to handle overflow and scroll #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should alleviate some problems when using a lot of social providers or using a landscape orientation on mobile.
damieng
approved these changes
Feb 14, 2020
jfromaniello
pushed a commit
to jfromaniello/auth0-lock
that referenced
this pull request
Mar 5, 2020
This should alleviate some problems when using a lot of social providers or using a landscape orientation on mobile.
davidpatrick
pushed a commit
to davidpatrick/lock
that referenced
this pull request
Jun 12, 2020
This should alleviate some problems when using a lot of social providers or using a landscape orientation on mobile.
jfromaniello
pushed a commit
to jfromaniello/auth0-lock
that referenced
this pull request
Jul 23, 2020
This should alleviate some problems when using a lot of social providers or using a landscape orientation on mobile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds stye rules to correctly contain the wrapper element whilst still allowing the login button to show at the bottom. This happens because, in order to fix an issue with the login button on mobile views,
overflow-x: autowas added to the wrapper element andoverflow-x: inheritwas added for desktop views. Asoverflow-ywas not also specified, it defaults tovisibleimplicitly (see this Stackoverflow answer). Explicitly specifyingoverflow-y: scrollhere causes the container to behave properly.The tradeoff is that it requires scrollbars to be hidden, otherwise it looks a bit ugly on Windows.
I identified #1758 as the change that broke the containing element and caused its contents to spill out.
Before
After
References
Fixes #1800
Fixes #1783
Checklist