Split configuration into Next and Base config #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/auth0/nextjs-auth0/ddpz5pzsw [Deployment for a52b686 canceled] |
adamjmcgrath
commented
Jan 29, 2021
| * See {@link Config} | ||
| * @ignore | ||
| */ | ||
| export type NextConfig = Pick<BaseConfig, 'routes' | 'identityClaimFilter'>; |
There was a problem hiding this comment.
To add custom routes
export interface NextConfig extends Pick<BaseConfig, 'identityClaimFilter'> {
routes: {
postLogoutRedirect: string;
callback: string;
login: string;
logout: string;
};
}
adamjmcgrath
changed the title
Widcket
reviewed
Jan 29, 2021
Widcket
requested changes
Jan 29, 2021
Widcket
reviewed
Feb 1, 2021
| login: Joi.alternatives([Joi.string().uri({ relativeOnly: true }), Joi.boolean().valid(false)]).default('/login'), | ||
| logout: Joi.alternatives([Joi.string().uri({ relativeOnly: true }), Joi.boolean().valid(false)]).default('/logout'), | ||
| callback: Joi.string().uri({ relativeOnly: true }).default('/callback'), | ||
| callback: Joi.string().uri({ relativeOnly: true }).required(), |
There was a problem hiding this comment.
The login and logout URLs don't need to be required?
There was a problem hiding this comment.
I've removed the login and logout URLs from the config as they are not used by auth0-session
Widcket
approved these changes
Feb 1, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
auth0-session) to make it easier to supply configuration that applies to the Next layer only (eg custom routes)auth0-sessionTesting
Checklist
master