Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vercel configuration docs #266

Merged
merged 4 commits into from
Feb 2, 2021
Merged

Conversation

frederikprijck
Copy link
Member

This PR updates the readme of the kitchen-sink example application to reflect recommendations around setting up Auth0 and Vercel.

  • Manual configuration
  • Brief explanation on Automating the configuration, including related links to the Vercel and Auth0 API v2 docs.
  • Avoid using wildcards without using a custom deployment suffix

The automating part serves the purpose to guide people towards building their own automated solution, not so much a plug and play solution from our end. It could be helpful to expand on this more, but it looks like a bit out of scope here. What do you think @adamjmcgrath?

@frederikprijck frederikprijck requested a review from a team as a code owner February 1, 2021 14:12
@vercel
Copy link

vercel bot commented Feb 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/auth0/nextjs-auth0/6u04mmffb
✅ Preview: Canceled

[Deployment for 7f148dc canceled]

@frederikprijck frederikprijck added review:medium Medium review documentation Improvements or additions to documentation labels Feb 1, 2021

**Note**: As we are making use of Preview Deployments, we need to configure the above URLs using wildcards, as every preview deployment will get a unique URL.
##### Automating
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not include this section for now since it's an optional step and the instructions are already quite long

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it.

examples/README.md Outdated Show resolved Hide resolved
@frederikprijck frederikprijck merged commit 317def9 into beta Feb 2, 2021
@frederikprijck frederikprijck deleted the frederik/vercel-docs branch February 2, 2021 14:35
@Widcket Widcket mentioned this pull request Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation review:medium Medium review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants