Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an open redirect vulnerability via the
returnTo
parameter, via checking for whitespace characters.Chrome based browsers (in my testing) will trim off the tab character for a redirect, as defined in the URL parser spec. This leads to an open redirect through
returnTo
by setting it to something like/%09/google.com
.You can test this in chrome by executing the following in the console:
Testing
Include
returnTo=/%09/google.com
in the login, it should fail with this change.Checklist
main