Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engine spec in package.json is wrong #509

Closed
kastork opened this issue Jul 31, 2018 · 1 comment
Closed

Engine spec in package.json is wrong #509

kastork opened this issue Jul 31, 2018 · 1 comment

Comments

@kastork
Copy link

kastork commented Jul 31, 2018

The package.json says

  "engines": {
    "npm": ">=1.4.28",
    "node": ">=0.12"
  },

But the package really needs node >= 1.4 because of the use of Object.assign (and maybe other things).
@JacoKoster
Copy link
Contributor

You are right, this package currently has node 4 as the lowest version, so this should be updated.

@aakash2602 aakash2602 mentioned this issue Oct 3, 2018
Merged
aakash2602 added a commit to aakash2602/node-jsonwebtoken that referenced this issue Oct 16, 2018
@aakash2602
Updated node version
df0e40e 
Updated Node version from 0.12 to 4 in package.json Engines Spec

Fixes Issue auth0#509
ziluvatar pushed a commit that referenced this issue Oct 22, 2018
@aakash2602 @ziluvatar
Updating Node version in Engines spec in package.json (#528)
cfd1079 
* Updating Node version in package.json

Updated Node version from 0.12 to 1.4 in package.json engines

* Updated node version

Updated Node version from 0.12 to 4 in package.json Engines Spec

Fixes Issue #509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kastork @ziluvatar @JacoKoster