nbf claim validation should include clockTolerance #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -3,6 +3,7 @@ | |||
| import sinon from 'sinon'; | |||
| import { createJwt, now } from './helpers'; | |||
| import { jwtVerifier, InvalidTokenError } from '../src'; | |||
| import validate from '../src/validate.js'; | |||
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note test
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 340 340
Branches 99 99
=========================================
Hits 340 340
☔ View full report in Codecov by Sentry. |
ewanharris
approved these changes
Oct 9, 2023
Merged
This was referenced May 18, 2024
This was referenced May 25, 2024
This was referenced Jun 2, 2024
This was referenced Jul 31, 2024
This was referenced Aug 7, 2024
This was referenced Aug 15, 2024
This was referenced Aug 22, 2024
This was referenced Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pass
clockToleranceoption through tojoseso that additional JWT date claims (likenbf) get validated with clock tolerance.References
fixes #113