This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
Fix minor bugs in the grammar #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 24, 2015 11:29
In the grammar definition, arguments to replace() had a typo. Instead of "ag2", it should be "arg2". Also, substring() and replace() had an extra leading parenthesis defined in the grammar. This is fixed as well.
The definition for "decimal" did not label arguments correctly in the grammar. It is now fixed so that they get passed as args in the generated parser.
added 2 commits
January 26, 2016 13:41
- DateTimeOffset was not parsed correctly. - The method for returning a DateTimeOffset was not specified. - The "Z" is part of the offset, not the DateTime. It is required as part of DateTimeOffset, and now allowed as part of DateTime. - Added a unit test for parsing this correctly.
|
Thank you for your contribution and sorry for the delay :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the grammar definition, arguments to replace() had a typo. Instead of
"ag2", it should be "arg2".
Also, substring() and replace() had an extra leading parenthesis defined
in the grammar. This is fixed as well.
The definition for "decimal" did not label arguments correctly in the
grammar. It is now fixed so that they get passed as args in the
generated parser.