Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issuer/signature sequence test #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bwillis
Copy link

@bwillis bwillis commented Aug 12, 2015

The assertion signature/issuer sequence was being tested, but the response signature/issuer sequence wasn't. This PR adds a test that is failing because it is being added at the bottom of the SAMLResponse.

I looked into fixing and it seems a little difficult to do because the issuer tag is added here in node-samlp, but the assertion is generate in node-saml.

Any thoughts on this issue? Thanks!

The SAML 2.0 protocol defines a sequence for Signature and Issuer. This
test verifies that it is in the proper order, identical to the
Signature/Issuer order verified on the response assertion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant