Fix promise that never completes [SDK-3216] (#464)

auth0 · Mar 18, 2022 · 891e5b1 · 891e5b1
1 parent ea5f4d1
commit 891e5b1
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/src/webauth/__tests__/agent.spec.js b/src/webauth/__tests__/agent.spec.js
@@ -105,6 +105,19 @@ describe('Agent', () => {
         A0Auth0.error = new Error('failed to load');
         await expect(agent.show('https://auth0.com')).rejects.toMatchSnapshot();
       });
+
+      it('should reject with error when both error and redirectURL are missing', async () => {
+        NativeModules.A0Auth0.showUrl = (...args) => {
+          const callback = args[args.length - 1];
+          callback(null, null);
+        };
+        expect.assertions(1);
+        try {
+          await agent.show('https://auth0.com');
+        } catch (e) {
+          expect(e).toEqual(new Error('Unknown WebAuth error'));
+        }
+      });
     });
   });
 

diff --git a/src/webauth/agent.js b/src/webauth/agent.js
@@ -47,6 +47,8 @@ export default class Agent {
           resolve(redirectURL);
         } else if (closeOnLoad) {
           resolve();
+        } else {
+          reject(new Error('Unknown WebAuth error'));
         }
       });
     });