Fix promise that never completes [SDK-3216] #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
commented
Mar 18, 2022
| @@ -105,6 +105,20 @@ describe('Agent', () => { | |||
| A0Auth0.error = new Error('failed to load'); | |||
| await expect(agent.show('https://auth0.com')).rejects.toMatchSnapshot(); | |||
| }); | |||
|
|
|||
| it('should reject with error when both error and redirectURL are missing', async () => { | |||
| NativeModules.A0Auth0.showUrl = (...args) => { | |||
There was a problem hiding this comment.
NativeModules.A0Auth0 gets reset on every test: https://github.com/auth0/react-native-auth0/blob/master/src/webauth/__tests__/agent.spec.js#L11
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When using Web Auth, after the native code calls the RN callback with an error or the redirect URL, the javascript code checks those values and either rejects or resolves a promise. But the code was not handling the case when both error and redirect URL are null, which can happen on iOS under particular circumstances (e.g. retrying the Web Auth login immediately after it failed).
This PR handles that case by rejecting the promise with an error.
References
Fixes #460
Testing
A unit test was added for this scenario, and also it was tested manually on iOS 15.4 (iPhone simulator), using React Native
0.66.4.Checklist