Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for ephemeral sessions [SDK-1412] #305

Merged
merged 7 commits into from
May 22, 2020
Merged

Added support for ephemeral sessions [SDK-1412] #305

merged 7 commits into from
May 22, 2020

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented May 19, 2020 •
edited
Loading

Changes

  • Added a new boolean parameter called ephemeralSession to the options object that sets prefersEphemeralWebBrowserSession to true on iOS 13+. It has no effect on older versions of iOS, or on Android. Usage of this method disables SSO.

References

Closes #294

Testing

This change was tested manually by performing login and logout on iOS and Android.

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket added CH: Added small This PR may require low effort to action, or contains few changes to review labels May 19, 2020
@Widcket Widcket requested a review from a team May 19, 2020 20:14
@Widcket Widcket added this to the v2-Next milestone May 19, 2020
@Widcket Widcket changed the title Added support for ephemeral sessions Added support for ephemeral sessions [SDK-1412] May 19, 2020
lbalmaceda
lbalmaceda suggested changes May 20, 2020
View reviewed changes
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. We've received many similar issues talking about that iOS "app wants to login with" dialog. Would it make sense to give this new option a mention somewhere on the readme?

src/webauth/agent.js Show resolved Hide resolved
src/webauth/index.js Outdated Show resolved Hide resolved
Widcket and others added 2 commits May 20, 2020 11:41
@Widcket
Add unit tests
d6502a1
@Widcket @lbalmaceda
Update src/webauth/index.js
e2db8d1 
Co-authored-by: Luciano Balmaceda <balmacedaluciano@gmail.com>
@Widcket Widcket mentioned this pull request May 21, 2020
Closed
@Widcket Widcket requested a review from lbalmaceda May 21, 2020 19:10
lbalmaceda
lbalmaceda reviewed May 21, 2020
View reviewed changes
src/webauth/__tests__/agent.spec.js Show resolved Hide resolved
src/webauth/agent.js Show resolved Hide resolved
src/webauth/agent.js Outdated Show resolved Hide resolved
src/webauth/index.js Show resolved Hide resolved
Widcket and others added 2 commits May 21, 2020 18:55
@Widcket @lbalmaceda
Update src/webauth/agent.js
1209022 
Co-authored-by: Luciano Balmaceda <balmacedaluciano@gmail.com>
@Widcket
Add unit test
405b4a2
@Widcket Widcket requested a review from lbalmaceda May 21, 2020 22:15
@Widcket Widcket merged commit a24bb31 into master May 22, 2020
@Widcket Widcket deleted the feature/ephemeral-session-support branch May 22, 2020 19:17
@conorcussell conorcussell mentioned this pull request Jun 5, 2020
Closed
@lbalmaceda lbalmaceda modified the milestones: v2-Next, v2.4.0 Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
CH: Added small This PR may require low effort to action, or contains few changes to review
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.

Getting signin popup during logout
2 participants
@Widcket @lbalmaceda