Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider passes params #540

Closed
wants to merge 7 commits into from
Closed

provider passes params #540

wants to merge 7 commits into from

Conversation

ebg1223
Copy link

@ebg1223 ebg1223 commented Oct 20, 2022

Changes

Fixes issue in hooks that prevents passing params to authorize()

References

#539

Checklist

@ebg1223
Copy link
Author

ebg1223 commented Oct 20, 2022

PR now includes clearCredentials() method in the useAuth0 hook, so that ios users can clear device credentials without browser prompt.

@ebg1223
Copy link
Author

ebg1223 commented Oct 20, 2022

added test for ephemeralsession and passing other tests. should be able to be merged if you agree with these inclusions @poovamraj

@poovamraj
Copy link
Contributor

Hi @ebg1223. Thanks for raising this! Looks like this is a regression added during this PR when we made hooks have default scopes - #522

We will check out your PR and fix this soon. Since your PR also adds a clearCredentials method, It will be added as a separate PR possibly with a different API.

@poovamraj
Copy link
Contributor

Hi @ebg1223, we have addressed these issues and enhancements in the following PRs.

#543
#542

Since it required a change in the API design we will go ahead with the above PRs and close this one. Thanks a lot for your contribution!

@poovamraj poovamraj closed this Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants