Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore method signatures #174

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

evansims
Copy link
Member

Changes

5.2.0 inadvertently altered some method signatures due to new code styling tooling rules; this restores those methods to their previous state, to avoid introducing breaking changes.

References

Resolves #173

Testing

N/A

Checklist

@evansims evansims added the Scope: Bug Addressing unexpected problems or unintended behavior. label Dec 14, 2023
@evansims evansims marked this pull request as ready for review December 15, 2023 00:00
@evansims evansims requested a review from a team as a code owner December 15, 2023 00:00
@evansims evansims enabled auto-merge (squash) December 15, 2023 00:00
@evansims evansims merged commit 67620e4 into main Dec 15, 2023
17 checks passed
@evansims evansims deleted the fix/rector-signature-changes branch December 15, 2023 11:10
@evansims evansims mentioned this pull request Dec 17, 2023
evansims added a commit that referenced this pull request Dec 19, 2023
**Fixed**
- Restore method signatures
[\#174](#174)
([evansims](https://github.com/evansims))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Bug Addressing unexpected problems or unintended behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[5.1.0 -> 5.2.0] Argument $logger no more existing in Auth0\Symfony\Service
2 participants