[5.1.0 -> 5.2.0] Argument $logger no more existing in Auth0\Symfony\Service

[fullmoonissue]

Checklist

• I have looked into the Readme and have not found a suitable solution or answer.
• I have searched the issues and have not found a suitable solution or answer.
• I have searched the Auth0 Community forums and have not found a suitable solution or answer.
• I agree to the terms within the Auth0 Code of Conduct.

Description

Hi 👋,

Thanks for the lastest release taking care of Sf v6.4.

Dependabot has tried to upgrade the auth0/symfony package from 5.1.0 to 5.2.0 but this error is encountered in the CI.

In ResolveNamedArgumentsPass.php line 87:

  [Symfony\Component\DependencyInjection\Exception\InvalidArgumentException]
  Invalid service "auth0": method "Auth0\Symfony\Service::__construct()" has no argument named "$logger". Check your service definition.

Checking the compare between the two versions, we can see that the argument $logger has been removed from the class Service (cf) but it has been kept in the service definition (cf).

Locally, when removing the $logger argument inside the Auth0Bundle from the Service class (and rebuild the symfony cache), the same error appears for the Auth0\Symfony\Security\Authenticator, Auth0\Symfony\Stores\SessionStore and Auth0\Symfony\Security\Authorizer too.

After removing all the $logger arguments from the definitions, a new error appears : Invalid service "Auth0\Symfony\Security\UserProvider": class has no constructor., so I've added a __construct() method like this :

    public function __construct(
        private Service $service,
    )
    {
    }

After those updates, the cache clears.

Do I mistaken about the spotted errors ?

If desired, I can make a PR with the mentioned updates.

Kind regards,

Reproduction

Trying to upgrade from the version 5.1.0 to 5.2.0.

Additional context

No response

jwt-auth-bundle version

5.2.0

Symfony version

6.4.1

PHP version

8.2.11

[evansims]

Hi @fullmoonissue 👋 Thanks for reporting this! Looks like some things got caught up in an overzealous Rector rule, with the new code styling getting applied. Apologies for not catching that. I'll get a fix going right away.

[evansims]

👋 Could you give b752dcc a look and see if that resolves all the inadvertent method signature alterations you identified? It might be worth pointing your composer entry for the SDK to the https://github.com/auth0/symfony/tree/fix/rector-signature-changes branch and trying it out, just to be sure.

[fullmoonissue]

Hi @evansims,

Thanks for the quick reply.

Indeed, when branching on dev-fix/rector-signature-changes from composer there's no more issue afterwards, nice.

It's a ✅ on my side.

[evansims]

Excellent, thanks so much for confirming that for me! I'll get a patch release going with that fix right now