Allow symfony/framework-bundle 4.x #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nightio
approved these changes
Jun 22, 2018
nightio
approved these changes
Jun 22, 2018
|
Just tested this against our quickstart sample by installing and configuring in Symfony 3, then upgrading to 4. Everything works as expected. One thing to note for anyone starting a new Symfony 4 application with this library: the quickstart needs some tweaking. We're going to assign this internally to either update to 4 entirely or provide steps for both. Thanks @ricbra! Fixes #55 |
joshcanhelp
approved these changes
Jun 22, 2018
|
It is possible to publish new bundle version after approve this PR? |
|
@artemchalenko - absolutely. I have one more fix I want to put through (#54) and then we'll release them both together. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for installation under symfony/symfony 4.x.