Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused argument, and unused property #95

Merged
merged 3 commits into from
Jun 9, 2020

Conversation

dunglas
Copy link
Contributor

@dunglas dunglas commented Feb 3, 2020

Changes

Remove dead code.

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

[x] This change adds test coverage

[x] This change has been tested on the latest version of Symfony

Checklist

[x] I have read the Auth0 general contribution guidelines

[x] I have read the Auth0 Code of Conduct

[x] All existing and new tests complete without errors

@dunglas dunglas requested a review from a team February 3, 2020 14:13
@stale
Copy link

stale bot commented May 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️

@stale stale bot added the closed:stale label May 3, 2020
@darthf1
Copy link
Contributor

darthf1 commented May 5, 2020

ping @lbalmaceda @joshcanhelp

@stale stale bot removed the closed:stale label May 5, 2020
@lbalmaceda lbalmaceda self-requested a review June 9, 2020 15:15
@lbalmaceda lbalmaceda merged commit 79649f9 into auth0:master Jun 9, 2020
@Widcket Widcket added this to the 3.4.0 milestone Jun 22, 2020
@Widcket Widcket mentioned this pull request Jun 22, 2020
@Widcket
Copy link
Contributor

Widcket commented Jun 23, 2020

This is now out in 3.4.0.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants