DXCDT-216: Allowing explicitly empty values #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump github.com/auth0/go-auth0 from 0.10.1 to 0.11.0 Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 0.10.1 to 0.11.0. - [Release notes](https://github.com/auth0/go-auth0/releases) - [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md) - [Commits](auth0/go-auth0@v0.10.1...v0.11.0) --- updated-dependencies: - dependency-name: github.com/auth0/go-auth0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * [2/X] Refactor actions resource to allow for empty fields (#337) * Refactor actions resource to allow for empty fields * Refactor actions trigger binding resource to allow for empty fields * [3/X] Refactor attack protection resource to allow for empty fields (#338) * Refactor attack protection resource to allow for empty fields * [4/X] Refactor branding resources to allow for empty fields (#339) * Refactor branding resources to allow for empty fields * [5/X] Refactor client resources to allow for empty fields (#340) * Refactor client resources to allow for empty fields * [6/X] Refactor connection resources to allow for empty fields (#341) * Refactor client resources to allow for empty fields * Refactor connection resources to allow for empty fields * [7/X] Refactor guardian resources to allow for empty fields (#342) * Refactor guardian resources to allow for empty fields * Early return for erroneous guardian API requests * Early return for erroneous guardian API requests * [8/X] Refactor orgs to allow for empty fields and remove deprecated field (#343) * Refactor ors to allow for empty fields and remove deprecated field * [9/X] Refactor email resources to allow for empty fields (#344) * Refactor email resources to allow for empty fields * [10/X] Refactor resource server resources to allow for empty fields (#345) * Refactor resource server resources to allow for empty fields * [11/X] Refactor tenant resource to allow for empty fields (#346) * Refactor tenant resource to allow for empty fields * [12/X] Refactor custom domain resource to allow for empty fields (#347) * Refactor custom domain resource to allow for empty fields * [13/X] Refactor user resource to allow for empty fields (#348) * Refactor user resource to allow for empty fields * [14/X] Refactor role and rule resources to allow for empty fields (#349) * Refactor role and rule resources to allow for empty fields * [15/X] Refactor log stream resource to allow for empty fields (#350) * Refactor log stream resource to allow for empty fields * [16/X] Refactor prompts resource to allow for empty fields (#351) * Refactor prompts resource to allow for empty fields * [17/X] Refactor hooks resource to allow for empty fields (#352) Refactor hooks resource to allow for empty fields * Fix small issue with log stream filters * Adding user_id back in to tests Co-authored-by: Will Vedder <will.vedder@okta.com> Co-authored-by: Will Vedder <will.vedder@okta.com> * Removing default audience string replace * Removing unncessary check Co-authored-by: Will Vedder <will.vedder@okta.com> Co-authored-by: Will Vedder <will.vedder@okta.com> Co-authored-by: Will Vedder <will.vedder@okta.com> Co-authored-by: Will Vedder <will.vedder@okta.com> Co-authored-by: Will Vedder <will.vedder@okta.com> * Adding extra assertion Co-authored-by: Will Vedder <will.vedder@okta.com> Co-authored-by: Will Vedder <will.vedder@okta.com> Co-authored-by: Will Vedder <will.vedder@okta.com> Co-authored-by: Will Vedder <will.vedder@okta.com> * Adding test for multiple depss * Adding stop Co-authored-by: Will Vedder <will.vedder@okta.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sergiu Ghitea <28300158+sergiught@users.noreply.github.com> Co-authored-by: Will Vedder <will.vedder@okta.com>
sergiught
approved these changes
Oct 10, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Applying the helper functions created in #319 to expand functions for all Terraform resource types. These changes are made in lock-step with correlating Go SDK changes. The purpose of this refactor is to introduce first-class handling of empty values, as reported in #14.
Through this refactor though, many other bugs and DX improvements have been made, as well as dozens of additional tests to ensure appropriate functionality.
More context about the history and technical approach of this refactor can been seen here.
📚 References
📝 Checklist