[3/3] DXCDT-232: Add validation on identity_api for waad connections #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Codecov ReportBase: 86.81% // Head: 86.81% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
=======================================
Coverage 86.81% 86.81%
=======================================
Files 40 40
Lines 8527 8527
=======================================
Hits 7403 7403
Misses 863 863
Partials 261 261
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sergiught
force-pushed
the
patch/DXCDT-232-waad
branch
from
89f666b
to
9777b42
Compare
sergiught
changed the title
sergiught
force-pushed
the
patch/DXCDT-232-waad
branch
from
9777b42
to
1a96b7c
Compare
willvedd
approved these changes
Oct 18, 2022
* Fix update behavior or client_metadata * [1/3] DXCDT-243: Improve precision of branding theme fields with float64 instead of int (#369) Improve precision of branding theme fields with float64 instead of int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
We are adding validation on
connection.options.identity_apito only allow "microsoft-identity-platform-v2.0" or "azure-active-directory-v1.0" so it is in line with the error message we get from the API if we pass anything different:{ "statusCode": 400, "error": "Bad Request", "message": "The identity_api property contains an invalid value. Valid values are 'azure-active-directory-v1.0', 'microsoft-identity-platform-v2.0'", "errorCode": "invalid_body" }📚 References
🔬 Testing
📝 Checklist