-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 388: relax validation rules on initiate_login_uri to match API #389
Conversation
Codecov ReportBase: 86.74% // Head: 86.74% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
==========================================
- Coverage 86.74% 86.74% -0.01%
==========================================
Files 41 41
Lines 8730 8727 -3
==========================================
- Hits 7573 7570 -3
Misses 890 890
Partials 267 267
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate the contribution @mlni 💯 , everything's looking good, just left a tiny comment to clean up the code a little bit more after we remove the fragment validation.
@@ -610,7 +608,6 @@ func newClient() *schema.Resource { | |||
Optional: true, | |||
ValidateFunc: validation.All( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering now we only have 1 validation, let's skip using the validation.All
and simply replace it with validation.IsURLWithHTTPS
🙏🏻
ValidateFunc: validation.All( | |
ValidateFunc: validation.IsURLWithHTTPS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point, fixed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤝 Thanks a lot for the contribution @mlni 💯 !!
🔧 Changes
This PR relaxes the validation rules on
initiate_login_uri
field onauth0_client
resource to match what the Auth0 API accepts.📚 References
🔬 Testing
Tested locally by adding a URL containing a fragment to
initiate_login_uri
and verifying that it both passes validation and actually applies to a client on Auth0.📝 Checklist