Issue 388: relax validation rules on initiate_login_uri to match API #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 86.74% // Head: 86.74% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
==========================================
- Coverage 86.74% 86.74% -0.01%
==========================================
Files 41 41
Lines 8730 8727 -3
==========================================
- Hits 7573 7570 -3
Misses 890 890
Partials 267 267
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sergiught
requested changes
Nov 4, 2022
| @@ -610,7 +608,6 @@ func newClient() *schema.Resource { | |||
| Optional: true, | |||
| ValidateFunc: validation.All( | |||
There was a problem hiding this comment.
Considering now we only have 1 validation, let's skip using the validation.All and simply replace it with validation.IsURLWithHTTPS 🙏🏻
Suggested change
| ValidateFunc: validation.All( | |
| ValidateFunc: validation.IsURLWithHTTPS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
This PR relaxes the validation rules on
initiate_login_urifield onauth0_clientresource to match what the Auth0 API accepts.📚 References
🔬 Testing
Tested locally by adding a URL containing a fragment to
initiate_login_uriand verifying that it both passes validation and actually applies to a client on Auth0.📝 Checklist