ESD-25022: Add provider to push mfa to fix sns settings not getting propagated
#415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
changed the title
sergiught
force-pushed
the
patch/ESD-25022-guardian-push-sns
branch
from
8a3d8a2
to
542b468
Compare
sergiught
changed the title
sergiught
force-pushed
the
patch/ESD-25022-guardian-push-sns
branch
from
542b468
to
eac67b9
Compare
sergiught
commented
Dec 14, 2022
| "provider": { | ||
| Type: schema.TypeString, | ||
| Required: true, | ||
| ValidateFunc: validation.StringInSlice([]string{"guardian", "sns"}, false), |
There was a problem hiding this comment.
To note that we aren't currently providing "direct" provider configuration capabilities due to the functionality missing from the go-auth0 SDK. We will need to add support for the following endpoints to achieve that:
PUT /guardian/factors/push-notification/providers/fcm
PUT /guardian/factors/push-notification/providers/apns
PATCH /guardian/factors/push-notification/providers/fcm
PATCH /guardian/factors/push-notification/providers/apns
sergiught
changed the title
provider to push mfa to fix sns settings not getting propagated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
This PR adds the ability to manage the selected provider for MultiFactor Push Notification settings through the
auth0_guardianresource.This is needed because without properly selecting the provider to be sns, even if we update the custom app and sns settings, they won't take effect.
📚 References
🔬 Testing
📝 Checklist