Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue#515: Move check for config secrets from the read to the update in conn #517

Merged
merged 3 commits into from
Mar 3, 2023

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Mar 1, 2023

🔧 Changes

We are moving the check for unmanaged configuration secrets on Database Connections over from the read to the update func. The check should have only alerted the user when they're trying to update and not when reading as well, as the same func is also reused within the conn data source.

📚 References

🔬 Testing

This PR adds a new test as well that uses the import functionality of a pre-configured db conn with an unmanaged config secret. The test can only run with the test recordings due to the initial work needed to set it up.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught changed the title issue#515: Move checking for unmanaged config secrets from the read to the update issue#515: Move check for config secrets from the read to the update in conn Mar 1, 2023
@sergiught sergiught force-pushed the issue#515-conn-data-source-issue branch from ed875de to c8bd1c6 Compare March 1, 2023 17:18
@sergiught sergiught marked this pull request as ready for review March 1, 2023 17:26
@sergiught sergiught requested a review from a team as a code owner March 1, 2023 17:26
@sergiught sergiught marked this pull request as draft March 1, 2023 17:29
@sergiught sergiught force-pushed the issue#515-conn-data-source-issue branch from c8bd1c6 to dfa3a7c Compare March 1, 2023 17:43
@sergiught sergiught marked this pull request as ready for review March 1, 2023 17:48
@sergiught sergiught self-assigned this Mar 1, 2023
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense. Will give a preliminary approval but think we should have a brief comment in the test advising how to rerecord the HTTP recordings.

@sergiught sergiught force-pushed the issue#515-conn-data-source-issue branch from dfa3a7c to 77e0a9a Compare March 3, 2023 08:34
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2023

Codecov Report

Patch coverage: 76.00% and project coverage change: -0.02 ⚠️

Comparison is base (8668fd7) 85.39% compared to head (d7f7063) 85.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
- Coverage   85.39%   85.37%   -0.02%     
==========================================
  Files          75       75              
  Lines        9921     9931      +10     
==========================================
+ Hits         8472     8479       +7     
- Misses       1145     1147       +2     
- Partials      304      305       +1     
Impacted Files Coverage Δ
internal/auth0/connection/expand.go 95.98% <70.00%> (-0.97%) ⬇️
internal/auth0/connection/flatten.go 89.16% <100.00%> (-0.11%) ⬇️
internal/auth0/connection/resource.go 73.19% <100.00%> (+3.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sergiught sergiught merged commit 70a078a into main Mar 3, 2023
@sergiught sergiught deleted the issue#515-conn-data-source-issue branch March 3, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants