Don't override imported connection_client id #562
Conversation
There was a problem hiding this comment.
Appreciate the contribution @WesleyKlop! We weren't aware of pulumi internal mechanics, however we have other such similar import mechanics across other resources like auth0_organization_connection and auth0_organization_member. If we're going this path would you mind altering the import for those resources as well? So we have consistency? 🙏🏻
|
Yes ofcourse, will do! |
This id is not reproducible and since only 1 connection + client binding exists the imported id should be unique enough. This would also not cause repeated imports to differ
Some resources are not identified in the API so we should always overwrite their id. This is now clarified. In other cases the SetId call is removed when its key is composite. When Terraform has ownership (creates) a resource, a comment was not added.
@sergiught I changed it! :) |
There was a problem hiding this comment.
Thanks a lot for the contribution @WesleyKlop 💯 Great work and appreciate going the extra mile on this one 💪🏻
|
Thank you very much! :D |
🔧 Changes
This PR changes the
importConnectionClientfunction which handles the importing ofauth0_connection_clientresources. When repeatedly importing this resource (like is possible when using a tool like Pulumi) the imported connection client has a new id every time even though it has not changed. This causes the IaC tool to want to recreate the resource, which breaks your environment. Using just the combination ofconnection_id:client_idis unique enough and should be fine to use the identifier for this resource, since I don't think there is a situation where duplicates would exist. (and if they do, that sounds like a misconfiguration)The only change is that the internal id is now the same each time the same resource is imported.
🔬 Testing
This can be tested by importing connection clients!
📝 Checklist
I have added documentation for all new/changed functionality (or N/A)