Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-587: Remove computed property from set_user_root_attributes #602

Merged
merged 1 commit into from May 25, 2023

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented May 25, 2023

馃敡 Changes

As raised in #587 and #83, the Microsoft Azure AD Connection's set_user_root_attributes behavior is different than expected. In order to have the user profile sync on each login, this parameter needs to be omitted from the payload. To do so we need to remove the Computed property from the schema for this value. As well we update our docs to reflect this information.

馃摎 References

馃敩 Testing

馃摑 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@@ -503,19 +503,14 @@ var resourceSchema = map[string]*schema.Schema{
},

"set_user_root_attributes": {
Type: schema.TypeString,
Optional: true,
Computed: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we keep this as computed we won't be able to actually remove it from the update so we can have it use default for WAAD conns.

@sergiught sergiught marked this pull request as ready for review May 25, 2023 10:37
@sergiught sergiught requested a review from a team as a code owner May 25, 2023 10:37
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution 馃憤

@sergiught sergiught merged commit 26d2ecb into main May 25, 2023
4 checks passed
@sergiught sergiught deleted the patch/GH-587-waad-docs branch May 25, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants