Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Validate all sections of ACLs on startup #1595

Merged
merged 3 commits into from
Jan 16, 2021

Conversation

nightah
Copy link
Member

@nightah nightah commented Jan 13, 2021

This change ensures that all sections of the access_control key are validated on startup.

@authelia
Copy link

authelia bot commented Jan 13, 2021

Artifacts

These changes are published for testing on Buildkite and DockerHub.

Docker Container

  • docker pull authelia/authelia:misc-authorization-coverage

This change ensure that all sections of the `access_control` key are validated on startup.
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #1595 (4b42fc4) into master (57c339b) will increase coverage by 0.55%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1595      +/-   ##
==========================================
+ Coverage   67.36%   67.91%   +0.55%     
==========================================
  Files         145      145              
  Lines        4100     4096       -4     
  Branches      168      168              
==========================================
+ Hits         2762     2782      +20     
+ Misses       1113     1100      -13     
+ Partials      225      214      -11     
Flag Coverage Δ
backend 69.00% <100.00%> (+0.70%) ⬆️
frontend 63.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/authorization/subject_matcher.go 100.00% <ø> (+16.66%) ⬆️
internal/authorization/ip_matcher.go 100.00% <100.00%> (+8.00%) ⬆️
internal/authorization/path_matcher.go 100.00% <100.00%> (+25.00%) ⬆️
internal/configuration/validator/access_control.go 100.00% <100.00%> (+64.00%) ⬆️
internal/configuration/validator/configuration.go 100.00% <100.00%> (ø)
internal/authorization/authorizer.go 100.00% <0.00%> (+4.16%) ⬆️

Copy link
Member

@james-d-elliott james-d-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nightah nightah merged commit 81e34d8 into master Jan 16, 2021
@nightah nightah deleted the misc-authorization-coverage branch January 16, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants