Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify AuthUI to support linking accounts #4109

Closed
1 task
fungc-io opened this issue Apr 9, 2024 — with Linear · 7 comments
Closed
1 task

Modify AuthUI to support linking accounts #4109

fungc-io opened this issue Apr 9, 2024 — with Linear · 7 comments
Assignees

Comments

Copy link
Member

fungc-io commented Apr 9, 2024

image.png

Figma: https://www.figma.com/file/LRE8EfCaTfYxC0lk5AeMmE/New-Auth-UI?type=design&node-id=2365-15938&mode=design&t=LXscrPWftY0rV2Wc-4


  • Add prompt=login to provider
@fungc-io fungc-io self-assigned this Apr 9, 2024
Copy link

linear bot commented Apr 9, 2024

@fungc-io fungc-io changed the title Modify AuthUI to support merging accounts Modify AuthUI to support linking accounts Apr 9, 2024
Copy link
Member Author

fungc-io commented Apr 9, 2024

@tung2744 @louischan @newman see if the design above works?

Copy link
Member Author

fungc-io commented Apr 10, 2024

@tung2744 @joyz i've updated the design based on our discussion today. Any thoughts?:
The User will see this if they log in with Google for the 1st time, while it conflicts with an account that contains Email + PW, logged in with GitHub, have passkey set.

image.png

@fungc-io fungc-io assigned tung2744 and unassigned fungc-io Apr 22, 2024
Copy link
Contributor

Screenshot 2024-04-24 at 7.53.06 PM.png

@fungc-io There is a case that the user signed in to a incorrect oauth account after choosing sign in with OAuth. I've created this error message to handle the error, please let me know if any update is needed.

Copy link
Member Author

Ok 👌

Copy link
Contributor

tung2744 commented May 2, 2024

@fungc-io @louischan Sorry I've found one more problem in this issue. Now the config specify the "action" per linking, which means, the "action" of each conflicted identities could be different if they are conflicted by different linking config. So maybe the message of each button should be different.
As now we actually haven't support login without link, maybe for simplicity we always show "Log in to an existing account to link it", and revise the design later if we supported login without link?

Copy link
Member Author

fungc-io commented May 2, 2024

maybe for simplicity we always show "Log in to an existing account to link it", and revise the design later if we supported login without link

I agree

@fungc-io fungc-io closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants