Implement account linking in authui #4164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tung2744
force-pushed
the
dev1204
branch
3 times, most recently
from
4eafa57
to
22b33dd
Compare
tung2744
force-pushed
the
dev1204
branch
2 times, most recently
from
c3bd5fb
to
5bf45d3
Compare
tung2744
force-pushed
the
account-linking
branch
from
df8cd2e
to
84202a8
Compare
| @@ -1441,12 +1441,16 @@ const ( | |||
| ) | |||
|
|
|||
| type AuthenticationFlowAccountLinkingJSONPointer struct { | |||
| Pointer jsonpointer.T `json:"pointer,omitempty"` | |||
| Pointer string `json:"pointer,omitempty"` | |||
There was a problem hiding this comment.
I don't quite get what this bug is about from the commit title. Can you elaborate?
There was a problem hiding this comment.
@louischan-oursky I found the problem on adding e2e test. Basically the problem is if I parse /email into a jsonpointer.T, then I serialize the config. It will become #/email (Which looks like the expected behavior of the library)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref DEV-1204
ref #4109
requires #4159