ISS-51 single CSV report #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In case any consumer needs this - Backward compatibility maintained
- No more maintained by timestamp wise - Fixed logback to print full qualified package names
authorjapps
reviewed
Apr 14, 2018
| import static org.apache.http.entity.ContentType.APPLICATION_JSON; | ||
| import static org.jsmart.zerocode.core.utils.HelperJsonUtils.getContentAsItIsJson; | ||
|
|
||
| public class CorporateProxyNoSslContextHttpClient implements BasicHttpClient { |
There was a problem hiding this comment.
cover with test and create a sample please!
There was a problem hiding this comment.
you need a actual proxy or a mock proxy to test this. Will do this later. Issue #63 has been raised to address this.
authorjapps
reviewed
Apr 14, 2018
| @@ -74,6 +74,7 @@ public Response execute(String httpUrl, String methodName, Map<String, Object> h | |||
| if (headers != null) { | |||
| Map headersMap = headers; | |||
| for (Object key : headersMap.keySet()) { | |||
| removeDuplicateHeaders(requestBuilder, (String) key); | |||
authorjapps
approved these changes
Apr 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.