Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme code example for calling the API is wrong #96

Closed
DGuhr opened this issue Feb 6, 2023 · 0 comments
Closed

Readme code example for calling the API is wrong #96

DGuhr opened this issue Feb 6, 2023 · 0 comments

Comments

@DGuhr
Copy link
Contributor

DGuhr commented Feb 6, 2023

https://github.com/authzed/authzed-go/blob/main/README.md#performing-an-api-call <- this references a &pb

using this in a project leads to this outcome:
Screenshot 2023-02-06 at 11 31 44

the recommended package is actually wrong, the right way is to simply use &v1 instead, see
Screenshot 2023-02-06 at 11 31 52

Will provide a PR shortly.
@vroldanbet vroldanbet mentioned this issue Feb 6, 2023
Closed
DGuhr added a commit to DGuhr/authzed-go that referenced this issue Feb 6, 2023
@DGuhr
Fix authzed#96
ea10beb 
Also adds intellij local environment files to .gitignore

Signed-off-by: Dominik Guhr <dguhr@redhat.com>
DGuhr added a commit to DGuhr/authzed-go that referenced this issue Feb 6, 2023
@DGuhr
Fix authzed#96
986287e 
Also adds intellij local environment files to .gitignore

Signed-off-by: Dominik Guhr <dguhr@redhat.com>
DGuhr added a commit to DGuhr/authzed-go that referenced this issue Feb 6, 2023
@DGuhr
Fix authzed#96
775b5ba 
Also adds intellij local environment files to .gitignore

Signed-off-by: Dominik Guhr <dguhr@redhat.com>
DGuhr added a commit to DGuhr/authzed-go that referenced this issue Feb 6, 2023
@DGuhr
Fix authzed#96
b749065 
Also adds intellij local environment files to .gitignore

Signed-off-by: Dominik Guhr <dguhr@redhat.com>
DGuhr added a commit to DGuhr/authzed-go that referenced this issue Feb 6, 2023
@DGuhr
Fix authzed#96
fb21e0d 
Also adds intellij local environment files to .gitignore

Signed-off-by: Dominik Guhr <dguhr@redhat.com>
vroldanbet added a commit that referenced this issue Feb 6, 2023
@vroldanbet
Merge pull request #97 from DGuhr/iss96_readmefix
7f73e36 
Fix #96 - fix example API call in README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DGuhr