Move @types/jasmine into devDependencies #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sjaakiejj Please rebase on main to get the CI tests to run. Thanks! |
Types should always be specified as devDependencies. In this particular case, the inclusion of @types/jasmine in the compiled package leads to conflicts in systems that make use of Jest
The workflow file still didn't trigger test runs since the changes only applied to the main branch. I've updated the github workflow file now to also trigger on PRs. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types should always be specified as devDependencies. In this particular case, the inclusion of @types/jasmine in the compiled package leads to conflicts in systems that make use of Jest