pause: support unpausing object by removing the label #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzelinskie
approved these changes
Jan 11, 2023
conditions/conditions.go
Outdated
| func (s StatusWithConditions[S]) GetStatusConditions() []metav1.Condition { | ||
| return *s.Status.GetStatusConditions() | ||
| func (s *StatusWithConditions[S]) GetStatusConditions() *[]metav1.Condition { | ||
| var nilS S |
There was a problem hiding this comment.
I've been calling these variables "zero" since it's a trick to get the zero value for a type.
ecordell
commented
Jan 11, 2023
jzelinskie
approved these changes
Jan 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for removing the
pausedcondition when the pause label is removed (whether added by a user or a controller)Currently, unpausing requires both removing the label and editing the status to remove the condition, which is a pain (difficult to do without a kubectl plugin)