Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change release notes update mode #1150

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Change release notes update mode #1150

merged 2 commits into from
Feb 8, 2023

Conversation

ecordell
Copy link
Contributor

@ecordell ecordell commented Feb 8, 2023

This should make it so that we can make releases directly in GH ui, and have goreleaser update it with the generated notes when it's done building.

From https://goreleaser.com/customization/release/:

  # What to do with the release notes in case there the release already exists.
  #
  # Valid options are:
  # - `keep-existing`: keep the existing notes
  # - `append`: append the current release notes to the existing notes
  # - `prepend`: prepend the current release notes to the existing notes
  # - `replace`: replace existing notes
  #
  # Default is `keep-existing`.
  mode: replace

Since we use the github-native release note generator, this should just replace the generated notes with the generate notes + our extra notes at the end.

this should make it so that we can make releases directly in GH ui, and have goreleaser update it with the generated notes when it's done building
@ecordell ecordell requested a review from a team as a code owner February 8, 2023 02:07
@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Feb 8, 2023
Copy link
Contributor

@vroldanbet vroldanbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

It appears the change did not trigger the test-suite, and those being required means it's blocking merge

@jzelinskie jzelinskie merged commit 338b98a into main Feb 8, 2023
@jzelinskie jzelinskie deleted the replace-notes-gh-release branch February 8, 2023 19:09
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants