makes dispatch metrics toggleable #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/CLI
vroldanbet
force-pushed
the
make-disabling-dispatcher-metrics-possible
branch
2 times, most recently
from
6954425
to
e4458ad
Compare
vroldanbet
force-pushed
the
make-disabling-dispatcher-metrics-possible
branch
2 times, most recently
from
5c53e28
to
c032a05
Compare
github-actions
bot
added
the
area/tooling
dispatch metrics tends to cause cryptic errors in tests when things are not tear down properly and an instance of the dispatcher isn't Closed. It also makes difficult running multiple spicedb in the same process. This makes those metrics: - disabled by default when instantiated programmatically - enabled by default in the serve command (as it currently stands before the change)
vroldanbet
force-pushed
the
make-disabling-dispatcher-metrics-possible
branch
from
c032a05
to
c0d33b0
Compare
jzelinskie
approved these changes
Feb 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dispatch metrics tends to cause cryptic errors
in tests when things are not tear down properly
and an instance of the dispatcher isn't Closed.
It also makes difficult running multiple spicedb
in the same process.
This makes those metrics: