Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve CRDB GC error message #1166

Merged
merged 1 commit into from
Feb 13, 2023
Merged

improve CRDB GC error message #1166

merged 1 commit into from
Feb 13, 2023

Conversation

vroldanbet
Copy link
Contributor

@vroldanbet vroldanbet commented Feb 13, 2023 •
edited

Closes #1158

unfortunately we cannot change the default CRDB GC value as that would be a breaking change for deployments relying heavily on at_exact_snapshot request consistency and Watch API.

  • For users of Cockroach dedicated, the value won't change automatically. Newly created clusters will have a GC of 4 hours, but users can change it
  • For users of Cockroach serverless the value will be automatically updated by the control plane to 1h15m - see release notes

@github-actions github-actions bot added the area/datastore Affects the storage system label Feb 13, 2023
@vroldanbet vroldanbet marked this pull request as ready for review February 13, 2023 18:23
@vroldanbet vroldanbet requested a review from a team as a code owner February 13, 2023 18:23
@vroldanbet vroldanbet mentioned this pull request Feb 13, 2023
Closed
@vroldanbet vroldanbet self-assigned this Feb 13, 2023
josephschorr
josephschorr approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vroldanbet vroldanbet merged commit 216c830 into main Feb 13, 2023
@vroldanbet vroldanbet deleted the improve-crdb-gc-warning branch February 13, 2023 18:38
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephschorr josephschorr josephschorr approved these changes

Assignees

@vroldanbet vroldanbet

Labels
area/datastore Affects the storage system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CockroachDB GC Window Change
2 participants
@vroldanbet @josephschorr