does not return an error if GC windows aren't aligned #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vroldanbet
force-pushed
the
do-not-terminate-of-gc-window-misalignment
branch
from
931bd7c
to
226b005
Compare
vroldanbet
force-pushed
the
do-not-terminate-of-gc-window-misalignment
branch
from
226b005
to
7de321e
Compare
josephschorr
approved these changes
Feb 15, 2023
so that spicedbs dont crashloop if cockroach changes Cockroach Serverless / Dedicated GC
vroldanbet
force-pushed
the
do-not-terminate-of-gc-window-misalignment
branch
from
7de321e
to
cbadd59
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that spicedbs dont crashloop if cockroach
changes Cockroach Serverless / Dedicated GC