Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makes the request caveat context size configurable #1190

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

vroldanbet
Copy link
Contributor

makes it possible to configure the caveat context
size enforcement. This is useful when some
schemas may end up hitting this limit easily, but
we still need to have a limit in place to prevent abuse.

@vroldanbet vroldanbet requested a review from a team as a code owner March 7, 2023 18:14
@github-actions github-actions bot added area/api v1 Affects the v1 API area/CLI Affects the command line area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Mar 7, 2023
pkg/cmd/serve.go Outdated Show resolved Hide resolved
@vroldanbet vroldanbet force-pushed the make-request-caveat-context-size-configurable branch 3 times, most recently from 6292fe6 to 36ab3a5 Compare March 7, 2023 18:23
makes it possible to configure the caveat context
size enforcement. This is useful when some
schemas may end up hitting this limit easily, but
we still need to have a limit in place to prevent abuse.

A value of zero or less means no limit
@vroldanbet vroldanbet force-pushed the make-request-caveat-context-size-configurable branch from 36ab3a5 to 0c25ac2 Compare March 7, 2023 19:23
@vroldanbet vroldanbet self-assigned this Mar 7, 2023
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vroldanbet vroldanbet merged commit 9bb7366 into main Mar 7, 2023
@vroldanbet vroldanbet deleted the make-request-caveat-context-size-configurable branch March 7, 2023 19:45
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/api v1 Affects the v1 API area/CLI Affects the command line area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants